linux-kernel - Re: [PATCH v2 net-next 1/4] net: implement support for low latency socket polling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5199EF6F.9040008@linux.intel.com>
Date:	Mon, 20 May 2013 12:39:59 +0300
From:	Eliezer Tamir <eliezer.tamir@...ux.intel.com>
To:	David Miller <davem@...emloft.net>
CC:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	jesse.brandeburg@...el.com,
	"Skidmore, Donald C" <donald.c.skidmore@...el.com>,
	e1000-devel@...ts.sourceforge.net, willemb@...gle.com,
	andi@...stfloor.org, hpa@...or.com, eliezer@...ir.org.il
Subject: Re: [PATCH v2 net-next 1/4] net: implement support for low latency
 socket polling

On 20/05/2013 10:54, David Miller wrote:
> From: Eliezer Tamir <eliezer.tamir@...ux.intel.com>
> Date: Sun, 19 May 2013 13:25:33 +0300
>
>> +#else /* CONFIG_INET_LL_RX_FLUSH */
>> +
>> +#define sk_valid_ll(sk) 0
>> +#define sk_poll_ll(sk, nonblock) do {} while (0)
>> +#define skb_mark_ll(napi, skb) do {} while (0)
>> +#define sk_mark_ll(sk, skb) do {} while (0)
>
> Make these inline functions too, so that even if
> CONFIG_INET_LL_RX_POLL is disabled, the arguments and return values
> are still properly type checked.

Is this what you had in mind?

static inline bool sk_valid_ll(struct sock *sk)
{
	return 0;
}

static inline bool sk_poll_ll(struct sock *sk, int noblock)
{
	return 0;
}

static inline void skb_mark_ll(struct sk_buff *skb, struct napi_struct 
*napi)
{
}

static inline voiv sk_mark_ll(struct sock *sk, struct sk_buff *skb)
{
}

would you like me to resend the whole set or just this patch?

Thanks,
Eliezer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/