linux-kernel - Re: [Consult] Why need we call device_remove_file() firstly before call device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51998699.4080202@asianux.com>
Date:	Mon, 20 May 2013 10:12:41 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	Ming Lei <tom.leiming@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [Consult] Why need we call device_remove_file() firstly before
 call device_unregister() ?

On 05/20/2013 09:45 AM, Greg Kroah-Hartman wrote:
> On Mon, May 20, 2013 at 09:03:27AM +0800, Chen Gang wrote:
>> > On 05/18/2013 07:06 PM, Ming Lei wrote:
>>> > > Hi,
>>> > > 
>>> > > On Fri, May 17, 2013 at 1:43 PM, Chen Gang <gang.chen@...anux.com> wrote:
>>>> > >> Hello All:
>>>> > >>
>>>> > >> I searched 'arch/*' and 'drivers/*' sub-directory, all of them are 'obey
>>>> > >> this rule', even in device_unregister() itself, it also firstly calls
>>>> > >> device_remove_file(), then call kobject_del().
>>>> > >>
>>>> > >> But after read the related code (fs/sysfs/*, drivers/base/core.c), it
>>>> > >> seems kobject_del() -> sysfs_remove_dir() which will release all related
>>>> > >> things (can instead of device_remove_file()).
>>>> > >>
>>>> > >> So in fact, we need not call device_remove_file() before call
>>>> > >> device_unregister(), is it correct ?
>>> > > 
>>> > > Looks it is correct but it is a bit implicit.
>>> > > 
>> > 
>> > If really no other members reply within a week, we should treat your
>> > opinion (or suggestion) as the final result conclusion within
>> > linux-kernel@...r.kernel.org.  :-)
> I have no idea what you mean by this.
> 

I mean that if no reply by any other members within a week, I will know
it is correct that "we need not call device_remove_file() firstly before
call device_unregister()" (at least, one member's reply supports this
conclusion).

I find this 'question' when discussing a patch with another members in
linux-kernel@...r.kernel.org, I have read the related code and also have
searched with google, but can not find the result, so I want to consult
it in linux-kernel@...r.kernel.org.

And I think, this 'question' is not suitable to give a test firstly,
because the test plan need be discussed firstly (or the test result
means nothing).


This time, I send the 'consult' mail to 'All', not to specific members.


Thanks.
-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/