linux-kernel - Re: [PATCH v2 6/7] PCI: Make sure VF's driver get attached after PF's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZOPZ+L1QJdHePd_x9RAoqZKyJAKHo+hA8T1UZoe8=ozT98RA@mail.gmail.com>
Date:	Mon, 20 May 2013 15:28:39 +0300
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	Greg Rose <gregory.v.rose@...el.com>
Cc:	Yinghai Lu <yinghai@...nel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Gu Zheng <guz.fnst@...fujitsu.com>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Alexander Duyck <alexander.h.duyck@...el.com>,
	Yan Burman <yanb@...lanox.com>,
	Sathya Perla <Sathya.Perla@...lex.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 6/7] PCI: Make sure VF's driver get attached after PF's

On Wed, May 15, 2013 at 7:12 PM, Greg Rose <gregory.v.rose@...el.com> wrote:

> I'm really not a fan of this.  Seems to me the tail is wagging the dog
> here.  Fix the driver to work without a PF driver being present.

Greg, Alex,

As I wrote over the V1 thread, currently we can't go and patch mlx4 to
use the sysfs API nor defer the call from within our probe function to
enable sriov since  this requires some firmware change to allow
enabling SRIOV after some  resources are initialized/provisioned.
Hence the patch suggested here or any other patch we can agree on
which will make sure that VF probing is done only once the PF is ready
is preferred, I think.

I wasn't sure to totally follow on the argument that things need to
work when the PF is absent in the sense there's no driver instance
around over which the PF is probed, if you can explain little better,
that would help.

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/