linux-kernel - Re: microcode loading got really slow.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hr4gyvv7r.wl%tiwai@suse.de>
Date:	Thu, 23 May 2013 12:36:40 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Ming Lei <tom.leiming@...il.com>
Cc:	Dave Jones <davej@...hat.com>, "H. Peter Anvin" <hpa@...or.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>, x86@...nel.org,
	fenghua.yu@...el.com
Subject: Re: microcode loading got really slow.

At Thu, 23 May 2013 18:27:57 +0800,
Ming Lei wrote:
> 
> On Thu, May 23, 2013 at 6:16 PM, Takashi Iwai <tiwai@...e.de> wrote:
> >
> > Thinking on this again, if the user-space continues to be broken in
> > that point, we should provide request_firmware() variant without udev,
> > e.g. request_firmware_direct(), and use it in known places like this?
> 
> As anish said, it has been already there,

No, f/w loader always fall back to user mode helper, as long as its
support is built in.  And doing that for microcode driver in that code
path isn't only superfluous but also broken due to request_firmware
call in module init.

> wrt. this problem, I think we
> need to know why the direct loading is failed.

The reason is obvious: the requested f/w file doesn't exist.
And it's fine, because the microcode update is an optional operation.
If no f/w file is found, it's not handled as an error.  It just means
that no need to update, continuing to work.

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/