linux-kernel - Re: [PATCH 2/2] regmap: Make regmap-mmio usable from different contexts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130523140503.GD2412@sirena.org.uk>
Date:	Thu, 23 May 2013 09:05:03 -0500
From:	Mark Brown <broonie@...nel.org>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Davide Ciminaghi <ciminaghi@...dd.com>,
	Stephen Warren <swarren@...dotorg.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] regmap: Make regmap-mmio usable from different
 contexts

On Thu, May 23, 2013 at 03:06:16PM +0200, Lars-Peter Clausen wrote:

> This patch updates the adds a flags parameter to the regmap lock and unlock
> callbacks and uses spin_lock_irqsave() and spin_unlock_restore() for the mmio
> case. This allows us to use regmap-mmio from different contexts.

This seems really invasive, why not just have the lock that gets passed
in point to a struct which has both the lock and the flags?  As far as
the core is concerned the lock is just whatever data is required to do
the locking, the fact that it's actually two values is an implementation
detail of this locking implementation.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)