linux-kernel - Re: [PATCH 1/2] regmap: regcache: Fixup locking for custom lock callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130523140856.GE2412@sirena.org.uk>
Date:	Thu, 23 May 2013 09:08:56 -0500
From:	Mark Brown <broonie@...nel.org>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Davide Ciminaghi <ciminaghi@...dd.com>,
	Stephen Warren <swarren@...dotorg.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] regmap: regcache: Fixup locking for custom lock
 callbacks

On Thu, May 23, 2013 at 03:06:15PM +0200, Lars-Peter Clausen wrote:
> The parameter passed to the regmap lock/unlock callbacks needs to be
> map->lock_arg, regcache passes just map. This works fine in the case that no
> custom locking callbacks are used, since in this case map->lock_arg equals map,
> but will break when custom locking callbacks are used. The issue was introduced
> in commit 0d4529c5 ("regmap: make lock/unlock functions customizable") and is
> fixed by this patch.

I've applied this but can you please also generate a version that
applies against v3.10-rc2 since this should really go in as a bug fix
but the patch depends on recent changes in the regcache code.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)