lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 26 May 2013 21:19:17 +0100 From: atomlin@...hat.com To: netdev@...r.kernel.org Cc: davem@...emloft.net, edumazet@...gle.com, pshelar@...ira.com, mst@...hat.com, alexander.h.duyck@...el.com, riel@...hat.com, aquini@...hat.com, sergei.shtylyov@...entembedded.com, linux-kernel@...r.kernel.org, Aaron Tomlin <atomlin@...hat.com> Subject: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets From: Aaron Tomlin <atomlin@...hat.com> Since v1: - Removed unnecessary parentheses ---8<--- Failed GFP_ATOMIC allocations by the network stack result in dropped packets, which will be received on a subsequent retransmit, and an unnecessary, noisy warning with a kernel backtrace. These warnings are harmless, but they still cause users to panic and file bug reports over dropped packets. It would be better to hide the failed allocation warnings and backtraces, and let retransmits handle dropped packets quietly. Signed-off-by: Aaron Tomlin <atomlin@...hat.com> --- net/core/skbuff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 02139d6..84aa870 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -236,7 +236,7 @@ struct sk_buff *__alloc_skb(unsigned int size, gfp_t gfp_mask, ? skbuff_fclone_cache : skbuff_head_cache; if (sk_memalloc_socks() && (flags & SKB_ALLOC_RX)) - gfp_mask |= (__GFP_MEMALLOC|__GFP_NOWARN); + gfp_mask |= __GFP_MEMALLOC | __GFP_NOWARN; /* Get the HEAD */ skb = kmem_cache_alloc_node(cache, gfp_mask & ~__GFP_DMA, node); -- 1.8.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists