linux-kernel - Re: [RFC PATCHv4 4/6] clocksource: TI-Nspire timer support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkda4Qe1e+dkcSgPLf5dcHASvOG=Y=Dvrnv=oGnon+FRzzg@mail.gmail.com>
Date:	Mon, 27 May 2013 12:53:14 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Daniel Tang <dt.tangr@...il.com>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux@....linux.org.uk ARM Linux" <linux@....linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>,
	"fabian@...ter-vogt.de Vogt" <fabian@...ter-vogt.de>,
	Lionel Debroux <lionel_debroux@...oo.fr>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	John Stultz <john.stultz@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC PATCHv4 4/6] clocksource: TI-Nspire timer support

On Sat, May 25, 2013 at 1:08 PM, Daniel Tang <dt.tangr@...il.com> wrote:

> Add clocksource and clockevent driver for the TI-Nspire.
>
> Signed-off-by: Daniel Tang <dt.tangr@...il.com>

This is *much* improved :-D

But:

> +++ b/drivers/clocksource/zevio-timer.c

> +static void zevio_timer_set_mode(enum clock_event_mode mode,
> +               struct clock_event_device *dev)
> +{
> +       unsigned long flags;
> +       struct zevio_timer *timer = container_of(dev,
> +                       struct zevio_timer,
> +                       clkevt);
> +
> +       local_irq_save(flags);
> +
> +       switch (mode) {
> +       case CLOCK_EVT_MODE_PERIODIC:
> +               /* Unsupported */
> +               break;
> +       case CLOCK_EVT_MODE_RESUME:
> +       case CLOCK_EVT_MODE_ONESHOT:
> +               /* Enable timer interrupts */
> +               writel(TIMER_INTR_MSK, timer->interrupt_regs + IO_INTR_MSK);
> +               writel(TIMER_INTR_ALL, timer->interrupt_regs + IO_INTR_ACK);
> +               dev->mode = mode;
> +               break;
> +       case CLOCK_EVT_MODE_SHUTDOWN:
> +       case CLOCK_EVT_MODE_UNUSED:
> +               /* Disable timer interrupts */
> +               writel(0, timer->interrupt_regs + IO_INTR_MSK);
> +               writel(TIMER_INTR_ALL, timer->interrupt_regs + IO_INTR_ACK);
> +               /* Stop timer */
> +               writel(CNTL_STOP_TIMER, timer->timer1 + IO_CONTROL);
> +               dev->mode = mode;
> +               break;
> +       }

Surely both the compiler and checkpatch is complaining that this
switch does not contain a default: clause?

If you fix this you can add my:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/