linux-kernel - Re: [RFC PATCHv4 4/6] clocksource: TI-Nspire timer support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <69E1F2A1-CD4C-4B16-8664-6010C7217B8B@gmail.com>
Date:	Mon, 27 May 2013 20:56:24 +1000
From:	Daniel Tang <dt.tangr@...il.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux@....linux.org.uk ARM Linux" <linux@....linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>,
	"fabian@...ter-vogt.de Vogt" <fabian@...ter-vogt.de>,
	Lionel Debroux <lionel_debroux@...oo.fr>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	John Stultz <john.stultz@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC PATCHv4 4/6] clocksource: TI-Nspire timer support


On 27/05/2013, at 8:53 PM, Linus Walleij <linus.walleij@...aro.org> wrote:

> On Sat, May 25, 2013 at 1:08 PM, Daniel Tang <dt.tangr@...il.com> wrote:
> 
>> Add clocksource and clockevent driver for the TI-Nspire.
>> 
>> Signed-off-by: Daniel Tang <dt.tangr@...il.com>
> 
> This is *much* improved :-D

Awesome!

>> +               /* Disable timer interrupts */
>> +               writel(0, timer->interrupt_regs + IO_INTR_MSK);
>> +               writel(TIMER_INTR_ALL, timer->interrupt_regs + IO_INTR_ACK);
>> +               /* Stop timer */
>> +               writel(CNTL_STOP_TIMER, timer->timer1 + IO_CONTROL);
>> +               dev->mode = mode;
>> +               break;
>> +       }
> 
> Surely both the compiler and checkpatch is complaining that this
> switch does not contain a default: clause?

Neither in fact. checkpatch.pl gives me a all-clear.

But, I'll clean it up anyway - seems cleaner that way XD.

> 
> If you fix this you can add my:
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> 
> Yours,
> Linus Walleij

Cheers,
Daniel Tang--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/