linux-kernel - [PATCH] virtio_pci: fix capability format, comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130528080816.GA23399@redhat.com>
Date:	Tue, 28 May 2013 11:08:16 +0300
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	virtualization@...ts.linux-foundation.org, kvm@...r.kernel.org
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	David Howells <dhowells@...hat.com>,
	Dave Jones <davej@...hat.com>, linux-kernel@...r.kernel.org
Subject: [PATCH] virtio_pci: fix capability format, comments

- queue size can actually be 0 which is not a power of 2
- fix capability format. PCI spec says:
	The layout of the information is vendor specific, except that the byte
	immediately following the “Next” pointer in the capability structure is
	defined to be a length field.
	This length field provides the number of bytes in the capability
	structure (including the ID and Next pointer bytes).

Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
---

This patch is on top of the new layout branch, too

 include/uapi/linux/virtio_pci.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h
index cda688f..a5ef8cd 100644
--- a/include/uapi/linux/virtio_pci.h
+++ b/include/uapi/linux/virtio_pci.h
@@ -129,6 +129,7 @@
 struct virtio_pci_cap {
 	__u8 cap_vndr;	/* Generic PCI field: PCI_CAP_ID_VNDR */
 	__u8 cap_next;	/* Generic PCI field: next ptr. */
+	__u8 cap_len;	/* Generic PCI field: capability length */
 	__u8 cfg_type;	/* One of the VIRTIO_PCI_CAP_*_CFG. */
 	__u8 bar;		/* Where to find it. */
 	__le32 offset;	/* Offset within bar. */
@@ -154,7 +155,7 @@ struct virtio_pci_common_cfg {
 
 	/* About a specific virtqueue. */
 	__le16 queue_select;		/* read-write */
-	__le16 queue_size;		/* read-write, power of 2. */
+	__le16 queue_size;		/* read-write, power of 2, or 0. */
 	__le16 queue_msix_vector;	/* read-write */
 	__le16 queue_enable;		/* read-write */
 	__le16 queue_notify_off;	/* read-only */
-- 
MST
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/