linux-kernel - Re: [PATCH] cciss: fix broken mutex usage in ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130529150342.7f16e4402c82227604931984@linux-foundation.org>
Date:	Wed, 29 May 2013 15:03:42 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Stephen M. Cameron" <scameron@...rdog.cce.hp.com>
Cc:	axboe@...nel.dk, stephenmcameron@...il.com,
	mikem@...rdog.cce.hp.com, linux-kernel@...r.kernel.org,
	thenzl@...hat.com
Subject: Re: [PATCH] cciss: fix broken mutex usage in ioctl

On Fri, 24 May 2013 14:28:41 -0500 "Stephen M. Cameron" <scameron@...rdog.cce.hp.com> wrote:

> If a new logical drive is added and the CCISS_REGNEWD ioctl is invoked
> (as is normal with the Array Configuration Utility) the process
> will hang as below.  It attempts to acquire the same mutex twice, once
> in do_ioctl() and once in cciss_unlocked_open().  The BKL was recursive,
> the mutex isn't.

huh, now that's a really old-school deadlock.  I wonder why lockdep
didn't shout about it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/