linux-kernel - Re: [PATCH] audit: wait_for_auditd() should use TASK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51A67C4F.9070106@redhat.com>
Date:	Wed, 29 May 2013 17:08:15 -0500
From:	Guy Streeter <streeter@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Oleg Nesterov <oleg@...hat.com>, Al Viro <viro@...iv.linux.org.uk>,
	Eric Paris <eparis@...hat.com>,
	David Woodhouse <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] audit: wait_for_auditd() should use TASK_UNINTERRUPTIBLE

On 05/29/2013 04:59 PM, Andrew Morton wrote:
> On Fri, 24 May 2013 19:39:25 +0200 Oleg Nesterov <oleg@...hat.com> wrote:
> 
>> audit_log_start() does wait_for_auditd() in a loop until
>> audit_backlog_wait_time passes or audit_skb_queue has a room.
>>
>> If signal_pending() is true this becomes a busy-wait loop,
>> schedule() in TASK_INTERRUPTIBLE won't block.
> 
> And that's game over for a uniprocessor non-preempt machine, yes?
> 
>> Reported-by: Guy Streeter <streeter@...hat.com>
> 
> And what did Guy report?  "that looks screwy"?  "my machine locked up"?
>

Our customer was in fact running a uniprocessor machine, and they reported a
system hang.
--Guy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/