linux-kernel - Re: [RFC PATCH] vfs: add permute operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130529230149.GJ2363@lenny.home.zabbo.net>
Date:	Wed, 29 May 2013 16:01:49 -0700
From:	Zach Brown <zab@...hat.com>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	Linux-Fsdevel <linux-fsdevel@...r.kernel.org>,
	Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Christoph Hellwig <hch@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Howells <dhowells@...hat.com>
Subject: Re: [RFC PATCH] vfs: add permute operation

> >> +static void sort_parents3(struct dentry **p)
> >> +void sort_parents(struct dentry **p, unsigned *nump)
> >
> > Yikes, that's a bunch of fiddly code.  Is it *really* worth all that to
> > avoid calling the generic sort helpers?
> 
> AFAICS, I cannot make the compare function transitive, e.g.:  A is
> descendant of C but B is unrelated.  Then what should cmp(A, B) and
> cmp(B, C) return?

Ah, of course.  I wasn't reading closely enough.

- z
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/