linux-kernel - Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130530113247.GI5180@sirena.org.uk>
Date:	Thu, 30 May 2013 12:32:47 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Kishon Vijay Abraham I <kishon@...com>
Cc:	lgirdwood@...il.com, ldewangan@...dia.com, sameo@...ux.intel.com,
	linux-kernel@...r.kernel.org, gg@...mlogic.co.uk,
	ian@...mlogic.co.uk, balbi@...com
Subject: Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

On Thu, May 30, 2013 at 04:26:33PM +0530, Kishon Vijay Abraham I wrote:

> Only compile tested. Just sent a patch to get some comments
> /ideas on how to handle such one off regulators.
> to handle

What's unclear or confusing?  This all looks really basic...

> +	palmas_smps_read(pmic->palmas, palmas_regs_info[id].ctrl_addr, &reg);
> +	reg &= ~PALMAS_SMPS10_CTRL_MODE_ACTIVE_MODE_MASK;
> +
> +	if (mode == REGULATOR_MODE_NORMAL)
> +		reg |= SMPS10_BOOST_EN;
> +
> +	if (mode == REGULATOR_MODE_FAST)
> +		reg |= SMPS10_SWITCH_EN;
> +
> +	if (mode == REGULATOR_MODE_IDLE)
> +		reg |= SMPS10_BYPASS_EN;
> +
> +	palmas_smps_write(pmic->palmas, palmas_regs_info[id].ctrl_addr, reg);
> +	return 0;

This looks like a switch statement and isn't there an update bits
operation?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)