linux-kernel - Re: [PATCH v2 2/3] video: xilinxfb: Do not use out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOZdJXVn9fyhgZKYc9fhJ=Gis9Nqdv1B8EqVNcaswKV5+iCQ1g@mail.gmail.com>
Date:	Thu, 30 May 2013 20:16:16 -0500
From:	Timur Tabi <timur@...i.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Michal Simek <michal.simek@...inx.com>,
	lkml <linux-kernel@...r.kernel.org>,
	Michal Simek <monstr@...str.eu>,
	Florian Tobias Schandinat <FlorianSchandinat@....de>,
	"linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>
Subject: Re: [PATCH v2 2/3] video: xilinxfb: Do not use out_be32 IO function

On Thu, May 30, 2013 at 5:04 PM, Arnd Bergmann <arnd@...db.de> wrote:
>
> This is probably missing barriers, and is wrong on systems on which
> the endianess of the device is different from the CPU.


I suggest what was done in fsl_ssi.c:

#ifdef PPC
#define read_ssi(addr)             in_be32(addr)
#define write_ssi(val, addr)         out_be32(addr, val)
#define write_ssi_mask(addr, clear, set) clrsetbits_be32(addr, clear, set)
#elif defined ARM
#define read_ssi(addr)             readl(addr)
#define write_ssi(val, addr)         writel(val, addr)
/*
 * FIXME: Proper locking should be added at write_ssi_mask caller level
 * to ensure this register read/modify/write sequence is race free.
 */
static inline void write_ssi_mask(u32 __iomem *addr, u32 clear, u32 set)
{
    u32 val = readl(addr);
    val = (val & ~clear) | set;
    writel(val, addr);
}
#endif
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/