linux-kernel - Re: [RFC] clocksource: Add clocksource drivers menu.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51AC446D.5070503@st.com>
Date:	Mon, 03 Jun 2013 08:23:25 +0100
From:	Srinivas KANDAGATLA <srinivas.kandagatla@...com>
To:	John Stultz <john.stultz@...aro.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [RFC] clocksource: Add clocksource drivers menu.

On 31/05/13 19:40, John Stultz wrote:
> 
> And only just now did I notice that there are user-prompts in the
> drivers/clocksource/Kconfig.
> 
> I suspect the platform support options can safely select the proper
> clocksource config options without requiring the user to configure it.
> For the most part this is the case, even so folks still introduced some
> unnecessary clocksource config options (unnecessary as they don't prompt
> the user, default to y and depend on another config).
> 
> It looks like only: CLKSRC_DBX500_PRCMU &
> CLKSRC_DBX500_PRCMU_SCHED_CLOCK prompt the user right now.
> 
> Can you explain why its necessary the user has to be prompted here?

The only reason is to do with "how we present *SCHED_CLOCK options"?

If we make the *SCHED_CLOCK options default without prompts, then we do
not need a menu. These options can be selected at platform level
Kconfigs. We could possible cleanup the existing prompts.

Or

Make *SCHED_CLOCK option as a prompt then we do need a menu as these
prompts appear randomly in the menuconfig.

Am happy with either approach.

Thanks,
srini

> 
> I know the situation isn't your fault, and you're just trying to clean
> things up here. However I'd much prefer removing the user-prompt and
> trying to remove unnecessary configs over creating a new config menu.
> And if there must be a user-selected config, I'd much rather it be a
> platform config option rather then some generic-seeming driver config.
> 
> thanks
> -john

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/