linux-kernel - Re: [RFC] clocksource: Add clocksource drivers menu.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51ACDE33.6060000@linaro.org>
Date:	Mon, 03 Jun 2013 11:19:31 -0700
From:	John Stultz <john.stultz@...aro.org>
To:	srinivas.kandagatla@...com
CC:	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [RFC] clocksource: Add clocksource drivers menu.

On 06/03/2013 12:23 AM, Srinivas KANDAGATLA wrote:
> On 31/05/13 19:40, John Stultz wrote:
>> And only just now did I notice that there are user-prompts in the
>> drivers/clocksource/Kconfig.
>>
>> I suspect the platform support options can safely select the proper
>> clocksource config options without requiring the user to configure it.
>> For the most part this is the case, even so folks still introduced some
>> unnecessary clocksource config options (unnecessary as they don't prompt
>> the user, default to y and depend on another config).
>>
>> It looks like only: CLKSRC_DBX500_PRCMU &
>> CLKSRC_DBX500_PRCMU_SCHED_CLOCK prompt the user right now.
>>
>> Can you explain why its necessary the user has to be prompted here?
> The only reason is to do with "how we present *SCHED_CLOCK options"?
>
> If we make the *SCHED_CLOCK options default without prompts, then we do
> not need a menu. These options can be selected at platform level
> Kconfigs. We could possible cleanup the existing prompts.

Right. This is what I'm asking for. Since there are only two options 
that prompt the user, I'm asking if there is a reason the user needs to 
be prompted.

I not, we can just remove the prompts and simplify the config.

If there is a valid reason to prompt the user, then we may need to add a 
menu, but I'd probably prefer we add the option in the platform menu, 
rather then generate a new driver menu.

thanks
-john

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/