linux-kernel - Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC5Y2nOcGdF=d6X-9ZimYMkfJD-spw6D81ZdB1o7ra0_05hkMg@mail.gmail.com>
Date:	Mon, 3 Jun 2013 11:18:21 -0700
From:	Ben Chan <benchan@...omium.org>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Sage Ahn <syahn@...semi.com>
Subject: Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either
 USB or MMC

Sorry, I meant to send the revised patch but got the wrong file.

I'll add the Reported-by field.

Thanks,
Ben

On Mon, Jun 3, 2013 at 10:48 AM, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
> On Mon, Jun 03, 2013 at 10:23:45AM -0700, Ben Chan wrote:
>> The gdm72xx driver needs to have either the USB or SDIO implementation
>> enabled to provide useful functionalities, so the driver should depend
>> on either USB or MMC.
>>
>> Signed-off-by: Ben Chan <benchan@...omium.org>
>> Cc: Sage Ahn <syahn@...semi.com>
>> ---
>>  drivers/staging/gdm72xx/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig
>> index 6905913..8af0dd4 100644
>> --- a/drivers/staging/gdm72xx/Kconfig
>> +++ b/drivers/staging/gdm72xx/Kconfig
>> @@ -4,7 +4,7 @@
>>
>>  menuconfig WIMAX_GDM72XX
>>       tristate "GCT GDM72xx WiMAX support"
>> -     depends on NET
>> +     depends on NET && (USB || MMC)
>
> Alan Stern already told you how this would not solve the problem, why
> did you resend it to me again?
>
> And you forgot the "Reported-by:" line above, giving proper credit to
> the person who told you about this problem.
>
> Please fix both of them and resend.
>
> thanks,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/