linux-kernel - Re: [RFC 0/5] Enable f2fs support inline data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 4 Jun 2013 13:23:57 +0900
From:	Namjae Jeon <linkinjeon@...il.com>
To:	Huajun Li <huajun.li@...el.com>
Cc:	jaegeuk.kim@...sung.com, linux-fsdevel@...r.kernel.org,
	huajun.li.lee@...il.com, namjae.jeon@...sung.com,
	linux-kernel@...r.kernel.org,
	linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [RFC 0/5] Enable f2fs support inline data

Hi. Huajun.

I agree jaegeuk's opinion.
Additionally, It is better that you describe the effect in change-log
when this feature is added to f2fs.
e.g.
    1. how much space is saved when storing kernel-tree(small files) ?
    2. small files creation performance test.
    3. file look-up performance test.
    4. other performance tools 's result.

Thanks.

2013/6/4 Jaegeuk Kim <jaegeuk.kim@...sung.com>:
> Hi,
>
> This feature is one of my todo items. ;)
> Thank you for the contribution.
>
> Before reviewing the below code intensively, we need to check the
> following issues.
>
> - deadlock conditions
> - FS consistency
> - recovery routine
>
> Could you check one more time?
> Thanks again,
>
> 2013-06-03 (월), 18:04 +0800, Huajun Li:
>> f2fs inode is so large, small files can be stored directly in the inode,
>> rather than just storing a single block address and storing the data elsewhere.
>>
>> This RFC patch set is just to enable f2fs support inline data: files less than
>> about 3.6K can be stored directly in inode block.
>>
>> TODO: make small dirs inline too.
>>
>>
>> Haicheng Li (3):
>>   f2fs: Add helper functions and flag to support inline data
>>   f2fs: Add interface for inline data support
>>   f2fs: add tracepoints to debug inline data operations
>>
>> Huajun Li (2):
>>   f2fs: Handle inline data read and write
>>   f2fs: Key functions to handle inline data
>>
>>  fs/f2fs/Kconfig             |   10 +++
>>  fs/f2fs/Makefile            |    1 +
>>  fs/f2fs/data.c              |   78 +++++++++++++++++++++-
>>  fs/f2fs/f2fs.h              |   70 +++++++++++++++++++
>>  fs/f2fs/file.c              |    9 ++-
>>  fs/f2fs/inline.c            |  156 +++++++++++++++++++++++++++++++++++++++++++
>>  fs/f2fs/inode.c             |    8 +++
>>  include/linux/f2fs_fs.h     |    5 ++
>>  include/trace/events/f2fs.h |   69 +++++++++++++++++++
>>  9 files changed, 402 insertions(+), 4 deletions(-)
>>  create mode 100644 fs/f2fs/inline.c
>>
>
> --
> Jaegeuk Kim
> Samsung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/