linux-kernel - Re: [PATCH, resend] pch_phub: re-use native MAC address parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3489856.nvZgTyoe0K@wuerfel>
Date:	Tue, 04 Jun 2013 16:38:11 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH, resend] pch_phub: re-use native MAC address parser

On Tuesday 04 June 2013 17:21:16 Andy Shevchenko wrote:

> > The easiest solution would be to
> > make the entire driver "depend on NET".
> 
> I don't feel that is good idea. Driver is an abstraction to the ROM,
> it doesn't mean you can't read ROM without network framework.

Right, makes sense.

> It seems proper solution is to move mac_pton() outside of CONFIG_NET,
> though I don't know how to do this easily.

If we want to use it outside of CONFIG_NET, it cannot be part of net/core/*.c.
Maybe we can move the function to lib/mac_pton.c instead and create a
Kconfig symbol that gets selected by CONFIG_NET and by any driver lib
PCH_PHUB that needs it.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/