linux-kernel - Re: [PATCH, resend] pch_phub: re-use native MAC address parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 4 Jun 2013 17:21:16 +0300
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH, resend] pch_phub: re-use native MAC address parser

On Tue, Jun 4, 2013 at 5:03 PM, Arnd Bergmann <arnd@...db.de> wrote:
> On Tuesday 28 May 2013, Andy Shevchenko wrote:
>> We have mac_pton() helper to parse MAC addresses.
>>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>> Acked-by: Arnd Bergmann <arnd@...db.de>
>
> Hmm, the patch has appeared in linux-next now, and I'm now getting
> randconfig build errors when CONFIG_NET is disabled, since
> mac_pton is undefined then.

Thanks for catching this.

> The easiest solution would be to
> make the entire driver "depend on NET".

I don't feel that is good idea. Driver is an abstraction to the ROM,
it doesn't mean you can't read ROM without network framework.
It seems proper solution is to move mac_pton() outside of CONFIG_NET,
though I don't know how to do this easily.

--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/