linux-kernel - Re: [PATCH 1/4] swim: Release memory region after incorrect return/goto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51AE311F.5060900@lvivier.info>
Date:	Tue, 04 Jun 2013 20:25:35 +0200
From:	Laurent Vivier <Laurent@...vier.info>
To:	Joe Perches <joe@...ches.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] swim: Release memory region after incorrect return/goto

Le 04/06/2013 16:44, Joe Perches a écrit :
> The code uses
>
> 	return foo;
> 	goto err_type;
>
> when instead the form should have been
>
> 	ret = foo;
> 	goto err_type;
>
> Here this causes a useful release_mem_region to be skipped.
>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>   drivers/block/swim.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/swim.c b/drivers/block/swim.c
> index 2f445b7..8ed6ccb 100644
> --- a/drivers/block/swim.c
> +++ b/drivers/block/swim.c
> @@ -893,7 +893,7 @@ static int swim_probe(struct platform_device *dev)
>   
>   	swim_base = ioremap(res->start, resource_size(res));
>   	if (!swim_base) {
> -		return -ENOMEM;
> +		ret = -ENOMEM;
>   		goto out_release_io;
>   	}
>   

Reviewed-by: Laurent Vivier <Laurent@...ier.EU>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/