linux-kernel - Re: [PATCH 2/2] staging/asus_oled fixed linebreak style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130605111512.GW28112@mwanda>
Date:	Wed, 5 Jun 2013 14:15:12 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Matthias Schid <aircrach115@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	cruz@...sive-dynamics.biz, jonbrett.dev@...il.com,
	linux-kernel@...cs.fau.de, linux-kernel@...r.kernel.org,
	sjakub@...il.com, joe@...ches.com, steffhip@...glemail.com,
	simon.puels@...il.com
Subject: Re: [PATCH 2/2] staging/asus_oled fixed linebreak style issue

On Wed, Jun 05, 2013 at 12:50:45PM +0200, Matthias Schid wrote:
> fixed a linebreak within an error message string coding style
> issue reported by checkpatch.pl
> 
> Signed-off-by: Matthias Schid <aircrach115@...il.com>
> Signed-off-by: Stefan Huber <steffhip@...glemail.com>
> Signed-off-by: Simon Puels <simon.puels@...il.com>
> ---
>  drivers/staging/asus_oled/asus_oled.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
> index 173fb9a..a7cd65a 100644
> --- a/drivers/staging/asus_oled/asus_oled.c
> +++ b/drivers/staging/asus_oled/asus_oled.c
> @@ -383,8 +383,7 @@ static int append_values(struct asus_oled_dev *odev, uint8_t val, size_t count)
>  		}
>  
>  		if (i >= odev->buf_size) {
> -			dev_err(odev->dev, "Buffer overflow! Report a bug:"
> -			       "offs: %d >= %d i: %d (x: %d y: %d)\n",
> +			dev_err(odev->dev, "Buffer overflow! Report a bug: offs: %d >= %d i: %d (x: %d y: %d)\n",
>  			       (int) odev->buf_offs, (int) odev->buf_size,
>  			       (int) i, (int) x, (int) y);

This could be improved:

			dev_err(odev->dev,
				"Buffer overflow! Report a bug: offs: %zu >= %d i: %zu (x: %zu y: %zu)\n",
			     	odev->buf_offs, odev->buf_size, i, x, y);

Printk fromats are documented in Documentation/printk-formats.txt.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/