linux-kernel - Re: [PATCH] Staging: anrdroid: sync.c: fixed all checkpatch errors and warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1370474043.2253.11.camel@joe-AO722>
Date:	Wed, 05 Jun 2013 16:14:03 -0700
From:	Joe Perches <joe@...ches.com>
To:	Aldo Iljazi <neonsync1@...il.com>
Cc:	gregh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: anrdroid: sync.c: fixed all checkpatch errors
 and warnings

On Wed, 2013-06-05 at 23:23 +0300, Aldo Iljazi wrote:
> diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
[]
> @@ -893,13 +892,13 @@ static void sync_print_obj(struct seq_file *s, struct sync_timeline *obj)
>  	if (obj->ops->timeline_value_str) {
>  		char value[64];
>  		obj->ops->timeline_value_str(obj, value, sizeof(value));
> -		seq_printf(s, ": %s", value);
> +		seq_puts(s, ": %s", value);

This is wrong and shouldn't compile without warning.

Is this an over aggressive conversion or did checkpatch
really complain on this line?  


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/