linux-kernel - Re: [PATCH 2/2] sata highbank: add bit-banged SGPIO driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130605231517.GP10693@mtj.dyndns.org>
Date:	Wed, 5 Jun 2013 16:15:17 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Mark Langsdorf <mark.langsdorf@...xeda.com>
Cc:	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org,
	grant.likely@...aro.org, rob.herring@...xeda.com,
	devicetree-discuss@...ts.ozlabs.org
Subject: Re: [PATCH 2/2] sata highbank: add bit-banged SGPIO driver support

Hello,

On Wed, Jun 05, 2013 at 05:31:48PM -0500, Mark Langsdorf wrote:
> +static void ecx_parse_sgpio(struct ecx_plat_data *pdata, u32 port, u32 state)
> +{
> +	if (state & ECX_ACTIVITY_BITS)
> +		pdata->sgpio_pattern |= sgpio_bit_shift(pdata, port,
> +						ECX_ACTIVITY_SHIFT);
> +	else
> +		pdata->sgpio_pattern &= sgpio_bit_shift(pdata, port,
> +						ECX_ACTIVITY_SHIFT);

Shouldn't it be "&= ~" instead of "&="?  You're trying to turn the bit
off, right?

Looks okay to me otherwise.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/