| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130607001756.GA7052@lizard.sbx05280.losalca.wayport.net> Date: Thu, 6 Jun 2013 17:17:57 -0700 From: Anton Vorontsov <anton@...msg.org> To: Jingoo Han <jg1.han@...sung.com> Cc: 'David Woodhouse' <dwmw2@...radead.org>, linux-kernel@...r.kernel.org, "'Jett.Zhou'" <jtzhou@...vell.com> Subject: Re: [PATCH 1/8] 88pm860x_battery: remove unnecessary platform_set_drvdata() On Mon, May 06, 2013 at 01:16:30PM +0900, Jingoo Han wrote: > The driver core clears the driver data to NULL after device_release > or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d > (device-core: Ensure drvdata = NULL when no driver is bound). > Thus, it is not needed to manually clear the device driver data to NULL. > > Signed-off-by: Jingoo Han <jg1.han@...sung.com> 1-8 applied, thanks a lot! Anton > --- > drivers/power/88pm860x_battery.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/power/88pm860x_battery.c b/drivers/power/88pm860x_battery.c > index d338c1c..dfcda3a 100644 > --- a/drivers/power/88pm860x_battery.c > +++ b/drivers/power/88pm860x_battery.c > @@ -992,7 +992,6 @@ static int pm860x_battery_remove(struct platform_device *pdev) > free_irq(info->irq_batt, info); > free_irq(info->irq_cc, info); > power_supply_unregister(&info->battery); > - platform_set_drvdata(pdev, NULL); > return 0; > } > > -- > 1.7.2.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists