[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMuHMdVg12Wm4fZYDdgV0m4+Bo76hm=nckGtSkobRfbsmNo2wA@mail.gmail.com>
Date: Sat, 8 Jun 2013 10:31:59 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Chen Gang <gang.chen@...anux.com>
Cc: Mike Frysinger <vapier@...too.org>,
Hirokazu Takata <takata@...ux-m32r.org>,
Martin Schwidefsky <schwidefsky@...ibm.com>,
Heiko Carstens <heiko.carstens@...ibm.com>,
Arnd Bergmann <arnd@...db.de>,
realmz paranoid <realmz6@...il.com>, linux390@...ibm.com,
"uclinux-dist-devel@...ckfin.uclinux.org"
<uclinux-dist-devel@...ckfin.uclinux.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
linux-m32r@...linux-m32r.org, linux-m32r-ja@...linux-m32r.org,
linux-s390@...r.kernel.org, Linux-Arch <linux-arch@...r.kernel.org>
Subject: Re: [PATCH] arch: asm-geniric: for atomic_set_mask() 1st param, use
'unsigned int' instead of 'unsigned long'
Haven't done a real review, but my eye fell on it:
On Sat, Jun 8, 2013 at 9:50 AM, Chen Gang <gang.chen@...anux.com> wrote:
> diff --git a/arch/m32r/include/asm/atomic.h b/arch/m32r/include/asm/atomic.h
> index 0d81697..233c743 100644
> --- a/arch/m32r/include/asm/atomic.h
> +++ b/arch/m32r/include/asm/atomic.h
> @@ -264,7 +264,7 @@ static __inline__ int __atomic_add_unless(atomic_t *v, int a, int u)
> }
>
>
> -static __inline__ void atomic_clear_mask(unsigned long mask, atomic_t *addr)
> +static __inline__ void atomic_clear_mask(unsigned int mask, atomic_t *addr)
> {
> unsigned long flags;
> unsigned long tmp;
Shouldn't this become "unsigned int tmp" for consistency, too?
> @@ -286,7 +286,7 @@ static __inline__ void atomic_clear_mask(unsigned long mask, atomic_t *addr)
> local_irq_restore(flags);
> }
>
> -static __inline__ void atomic_set_mask(unsigned long mask, atomic_t *addr)
> +static __inline__ void atomic_set_mask(unsigned int mask, atomic_t *addr)
> {
> unsigned long flags;
> unsigned long tmp;
Likewise.
There may be other places that need changes.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists