lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 08 Jun 2013 16:37:30 +0800 From: Chen Gang <gang.chen@...anux.com> To: Geert Uytterhoeven <geert@...ux-m68k.org> CC: Mike Frysinger <vapier@...too.org>, Hirokazu Takata <takata@...ux-m32r.org>, Martin Schwidefsky <schwidefsky@...ibm.com>, Heiko Carstens <heiko.carstens@...ibm.com>, Arnd Bergmann <arnd@...db.de>, realmz paranoid <realmz6@...il.com>, linux390@...ibm.com, "uclinux-dist-devel@...ckfin.uclinux.org" <uclinux-dist-devel@...ckfin.uclinux.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, linux-m32r@...linux-m32r.org, linux-m32r-ja@...linux-m32r.org, linux-s390@...r.kernel.org, Linux-Arch <linux-arch@...r.kernel.org> Subject: Re: [PATCH] arch: asm-geniric: for atomic_set_mask() 1st param, use 'unsigned int' instead of 'unsigned long' On 06/08/2013 04:31 PM, Geert Uytterhoeven wrote: > Haven't done a real review, but my eye fell on it: > Thank you for your review, firstly. > On Sat, Jun 8, 2013 at 9:50 AM, Chen Gang <gang.chen@...anux.com> wrote: >> > diff --git a/arch/m32r/include/asm/atomic.h b/arch/m32r/include/asm/atomic.h >> > index 0d81697..233c743 100644 >> > --- a/arch/m32r/include/asm/atomic.h >> > +++ b/arch/m32r/include/asm/atomic.h >> > @@ -264,7 +264,7 @@ static __inline__ int __atomic_add_unless(atomic_t *v, int a, int u) >> > } >> > >> > >> > -static __inline__ void atomic_clear_mask(unsigned long mask, atomic_t *addr) >> > +static __inline__ void atomic_clear_mask(unsigned int mask, atomic_t *addr) >> > { >> > unsigned long flags; >> > unsigned long tmp; > Shouldn't this become "unsigned int tmp" for consistency, too? > It seems better. (although I guess: for 'm32r', both 'long' and 'int' are 32-bit). I will wait for 1 day at least, if no additional suggestions or completions, I will send patch v2. >> > @@ -286,7 +286,7 @@ static __inline__ void atomic_clear_mask(unsigned long mask, atomic_t *addr) >> > local_irq_restore(flags); >> > } >> > >> > -static __inline__ void atomic_set_mask(unsigned long mask, atomic_t *addr) >> > +static __inline__ void atomic_set_mask(unsigned int mask, atomic_t *addr) >> > { >> > unsigned long flags; >> > unsigned long tmp; > Likewise. > > There may be other places that need changes. OK, I will check them. Thanks. -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists