lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Jun 2013 00:15:22 +0300 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Dan Carpenter <dan.carpenter@...cle.com> Cc: Emil Goode <emilgoode@...il.com>, David Woodhouse <dwmw2@...radead.org>, artem.bityutskiy@...ux.intel.com, andrew@...n.ch, Bill Pemberton <wfp5p@...ginia.edu>, Jingoo Han <jg1.han@...sung.com>, linux-mtd@...ts.infradead.org, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org Subject: Re: [PATCH] mtd: orion_nand: Improve error handling in orion_nand_probe On Sun, Jun 9, 2013 at 11:57 PM, Dan Carpenter <dan.carpenter@...cle.com> wrote: > On Sun, Jun 09, 2013 at 10:27:03PM +0300, Andy Shevchenko wrote: >> On Sun, Jun 9, 2013 at 10:17 PM, Dan Carpenter <dan.carpenter@...cle.com> wrote: >> > On Sun, Jun 09, 2013 at 08:15:20PM +0300, Andy Shevchenko wrote: >> >> What about another patch (that I guess should go first) that converts >> >> printk to dev_* or pr_*? >> >> > Huh, what? Those are two totally unrelated things. Emil's patch is >> > a bug fix. >> >> To be precise his patch is bugfix and cleanup at once. >> My proposal is to add a clean up patch. > > The printk idea isn't a bad one, it's just totally unrelated to what > the patch is doing. I don't agree with word 'totally'. It touches probe function and shuffles code there. > You can't just randomly tell people to do a > bunch of work for no reason. "Good bugfix, but before we apply it > you have to mow my lawn." In this particular case I didn't think it's a big deal to fix 3 printfs. Anyway, see patch in the next message. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists