linux-kernel - Re: [PATCH 12/15] ASoC: spear: Convert to use devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK9yfHygMQYpVRqrieyESJw9oZC5OzKoWWSUhYDYEd6KJigegA@mail.gmail.com>
Date:	Mon, 10 Jun 2013 17:36:50 +0530
From:	Sachin Kamat <sachin.kamat@...aro.org>
To:	Tushar Behera <tushar.behera@...aro.org>
Cc:	linux-kernel@...r.kernel.org, thierry.reding@...il.com,
	patches@...aro.org, alsa-devel@...a-project.org,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH 12/15] ASoC: spear: Convert to use devm_ioremap_resource

On 10 June 2013 17:05, Tushar Behera <tushar.behera@...aro.org> wrote:
> Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()")
> introduced devm_ioremap_resource() and deprecated the use of
> devm_request_and_ioremap().

This patch does a little more than just conversion. May that change
could be mentioned here.

>
> Signed-off-by: Tushar Behera <tushar.behera@...aro.org>
> CC: alsa-devel@...a-project.org
> CC: Liam Girdwood <lgirdwood@...il.com>
> CC: Mark Brown <broonie@...nel.org>
> ---
>  sound/soc/spear/spdif_out.c |   20 +++++---------------
>  1 file changed, 5 insertions(+), 15 deletions(-)
>
> diff --git a/sound/soc/spear/spdif_out.c b/sound/soc/spear/spdif_out.c
> index 4bde512..896ee7f 100644
> --- a/sound/soc/spear/spdif_out.c
> +++ b/sound/soc/spear/spdif_out.c
> @@ -282,27 +282,17 @@ static int spdif_out_probe(struct platform_device *pdev)
>         struct resource *res;
>         int ret;
>
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       if (!res)
> -               return -EINVAL;
> -
> -       if (!devm_request_mem_region(&pdev->dev, res->start,
> -                               resource_size(res), pdev->name)) {
> -               dev_warn(&pdev->dev, "Failed to get memory resourse\n");
> -               return -ENOENT;
> -       }
> -
>         host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL);
>         if (!host) {
>                 dev_warn(&pdev->dev, "kzalloc fail\n");
>                 return -ENOMEM;
>         }
>
> -       host->io_base = devm_request_and_ioremap(&pdev->dev, res->start,
> -                               resource_size(res));
> -       if (!host->io_base) {
> -               dev_warn(&pdev->dev, "ioremap failed\n");
> -               return -ENOMEM;
> +       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +       host->io_base = devm_ioremap_resource(&pdev->dev, res);
> +       if (IS_ERR(host->io_base)) {
> +               dev_warn(&pdev->dev, "devm_ioremap_resource failed\n");

This print is not needed as devm_ioremap_resource prints its own messages.


> +               return PTR_ERR(host->io_base);
>         }
>
>         host->clk = devm_clk_get(&pdev->dev, NULL);
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/