linux-kernel - Re: [PATCH 14/15] usb: phy: rcar-usb: Fix comment w.r.t. devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51B5C3D3.9000609@cogentembedded.com>
Date:	Mon, 10 Jun 2013 16:17:23 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Tushar Behera <tushar.behera@...aro.org>
CC:	linux-kernel@...r.kernel.org, thierry.reding@...il.com,
	patches@...aro.org, linux-usb@...r.kernel.org,
	Felipe Balbi <balbi@...com>
Subject: Re: [PATCH 14/15] usb: phy: rcar-usb: Fix comment w.r.t. devm_ioremap_resource

Hello.

On 10-06-2013 15:35, Tushar Behera wrote:

> Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()")
> introduced devm_ioremap_resource() and deprecated the use of
> devm_request_and_ioremap().

> Signed-off-by: Tushar Behera <tushar.behera@...aro.org>
> CC: linux-usb@...r.kernel.org
> CC: Felipe Balbi <balbi@...com>
> ---
>   drivers/usb/phy/phy-rcar-usb.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/drivers/usb/phy/phy-rcar-usb.c b/drivers/usb/phy/phy-rcar-usb.c
> index a35681b..23c3dd3 100644
> --- a/drivers/usb/phy/phy-rcar-usb.c
> +++ b/drivers/usb/phy/phy-rcar-usb.c
> @@ -161,7 +161,7 @@ static int rcar_usb_phy_probe(struct platform_device *pdev)
>   	 * CAUTION
>   	 *
>   	 * Because this phy address is also mapped under OHCI/EHCI address area,
> -	 * this driver can't use devm_request_and_ioremap(dev, res) here
> +	 * this driver can't use devm_ioremap_resource(dev, res) here
>   	 */
>   	reg0 = devm_ioremap_nocache(dev, res0->start, resource_size(res0));
>   	reg1 = devm_ioremap_nocache(dev, res1->start, resource_size(res1));

     I'm completely removing this comment in my series pushed thru 
renesas.git, so I advise this patch to be ignored not to create conflict 
in the future.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/