linux-kernel - Re: [PATCH v3 10/27] genirq: Split __irq_reserve_irqs from irq_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Jun 2013 21:42:59 +0200
From:	Alexander Gordeev <agordeev@...hat.com>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 10/27] genirq: Split __irq_reserve_irqs from
 irq_alloc_descs

On Mon, Jun 10, 2013 at 12:16:16PM -0700, Yinghai Lu wrote:
> On Mon, Jun 10, 2013 at 6:51 AM, Alexander Gordeev <agordeev@...hat.com> wrote:
> >> +/**
> >> + * irq_alloc_descs - allocate and initialize a range of irq descriptors
> >> + * @irq:     Allocate for specific irq number if irq >= 0
> >> + * @from:    Start the search from this irq number
> >> + * @cnt:     Number of consecutive irqs to allocate.
> >> + * @node:    Preferred node on which the irq descriptor should be allocated
> >> + * @owner:   Owning module (can be NULL)
> >> + *
> >> + * Returns the first irq number or error code
> >> + */
> >> +int __ref
> >> +__irq_alloc_descs(int irq, unsigned int from, unsigned int cnt, int node,
> >> +               struct module *owner)
> >> +{
> >> +     int start;
> >> +
> >> +     start = __irq_reserve_irqs(irq, from, cnt);
> >> +
> >> +     if (start < 0)
> >> +             return start;
> >> +
> >> +     return alloc_descs(start, cnt, node, owner);
> >
> > I think alloc_descs() fail path is needed before return.
> 
> __irq_reserve_irqs already return -EEXIST etc,
> 
> old kernel is like:
> 
> >> @@ -380,12 +377,36 @@ __irq_alloc_descs(int irq, unsigned int from, unsigned int cnt, int node,
> 
>        bitmap_set(allocated_irqs, start, cnt);
>        mutex_unlock(&sparse_irq_lock);
>      return alloc_descs(start, cnt, node, owner);
> 
>  err:
>       mutex_unlock(&sparse_irq_lock);
>       return ret;
> 
> so i don't change the fail path handling.

I rather meant the bits should be unset in case alloc_descs() failed.
But I failed to notice alloc_descs() does it. Therefore..

Reviewed-by: Alexander Gordeev <agordeev@...hat.com>

> Thanks
> 
> Yinghai

-- 
Regards,
Alexander Gordeev
agordeev@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/