linux-kernel - Re: [PATCH 12/12] ARM: msm: Migrate to common clock framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 12 Jun 2013 09:54:57 -0700
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Mike Turquette <mturquette@...aro.org>
CC:	David Brown <davidb@...eaurora.org>,
	Daniel Walker <dwalker@...o99.com>,
	Bryan Huntsman <bryanh@...eaurora.org>,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Saravana Kannan <skannan@...eaurora.org>
Subject: Re: [PATCH 12/12] ARM: msm: Migrate to common clock framework

On 06/11/13 15:28, Mike Turquette wrote:
> Quoting Stephen Boyd (2013-06-04 12:25:38)
>> Move the existing clock code in mach-msm to the common clock
>> framework. We lose our capability to set the rate of and enable a
>> clock through debugfs. This is ok though because the debugfs
>> features are mainly used for testing and development of new clock
>> code.
>>
>> To maintain compatibility with the original MSM clock code we
>> make a wrapper for clk_reset() that calls the struct msm_clk
>> specific reset function. This is necessary for the usb and sdcc
>> devices on MSM until a better suited API is made available.
>>
>> Cc: Saravana Kannan <skannan@...eaurora.org>
>> Cc: Mike Turquette <mturquette@...aro.org>
>> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
> I just went through this quickly and nothing popped out at me.  Nice
> diffstat btw!  Do you have any plans to move this to drivers/clk/msm ?
>
> Acked-by: Mike Turquette <mturquette@...aro.org>

Thanks Mike.

I plan to add mmio support under drivers/clk/msm. Moving this proc_comm
based code to drivers/clk/msm is possible but it would need to depend on
the 3 architectures that use it so that it isn't available or compiled
on our DT based platforms. We can do that later I suppose.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/