linux-kernel - Re: [PATCH] pwm: Fill in missing .owner fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130612195917.GA31835@mithrandir>
Date:	Wed, 12 Jun 2013 21:59:18 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Sachin Kamat <sachin.kamat@...aro.org>
Cc:	linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] pwm: Fill in missing .owner fields

On Wed, Jun 12, 2013 at 05:05:18PM +0530, Sachin Kamat wrote:
> Hi Thierry,
> 
> On 12 June 2013 16:59, Thierry Reding <thierry.reding@...il.com> wrote:
> > Some drivers don't set the .owner fields of the struct device_driver or
> > struct pwm_ops, which causes the module usage count to become wrong.
> 
> 
> Recently a patch [1] was added to solve this issue of missing .owner
> fileds in struct platform_driver.

Yes I saw that, but thought it might be good to initialize them anyway.
Especially since a couple of the drivers are I2C and I believe there's
no similar patch for those. It shouldn't be difficult to come up with
the corresponding patch, though.

I wonder if it'd make sense to remove all the explicit assignments of
.owner = THIS_MODULE in platform drivers once the patch you mentioned
has been merged. Cc'ing Greg to find out what he thinks about it.

> Probably something similar could be done for struct pwm_ops too?

Possibly. The issue isn't quite as bad in the PWM subsystem since I'm
now aware of the problem and will look for it specifically in the
future. It's a different matter for struct device_driver since that's
used all over the place.

Thierry

> [1] https://patchwork.kernel.org/patch/2612961/
> 
> -- 
> With warm regards,
> Sachin

Content of type "application/pgp-signature" skipped