linux-kernel - Re: [PATCH 05/11] cgroup: clean up css_[try]get() and css

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51B93096.5060702@huawei.com>
Date:	Thu, 13 Jun 2013 10:38:14 +0800
From:	Li Zefan <lizefan@...wei.com>
To:	Tejun Heo <tj@...nel.org>
CC:	<containers@...ts.linux-foundation.org>, <cgroups@...r.kernel.org>,
	<koverstreet@...gle.com>, <linux-kernel@...r.kernel.org>,
	<cl@...ux-foundation.org>
Subject: Re: [PATCH 05/11] cgroup: clean up css_[try]get() and css_put()

On 2013/6/13 5:03, Tejun Heo wrote:
> * __css_get() isn't used by anyone.  Fold it into css_get().
> 
> * Add proper function comments to all css reference functions.
> 
> This patch is purely cosmetic.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> ---
>  include/linux/cgroup.h | 48 ++++++++++++++++++++++++------------------------
>  1 file changed, 24 insertions(+), 24 deletions(-)
> 
> diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
> index 0e32855..7b16882 100644
> --- a/include/linux/cgroup.h
> +++ b/include/linux/cgroup.h
> @@ -94,33 +94,31 @@ enum {
>  	CSS_ONLINE	= (1 << 1), /* between ->css_online() and ->css_offline() */
>  };
>  
> -/* Caller must verify that the css is not for root cgroup */
> -static inline void __css_get(struct cgroup_subsys_state *css, int count)
> -{
> -	atomic_add(count, &css->refcnt);
> -}
> -
> -/*
> - * Call css_get() to hold a reference on the css; it can be used
> - * for a reference obtained via:
> - * - an existing ref-counted reference to the css
> - * - task->cgroups for a locked task
> +/**
> + * css_get - obtain a reference on the specified css
> + * @css: taget css

s/taget/target

> + *
> + * The caller must already have a reference.
>   */
> -
>  static inline void css_get(struct cgroup_subsys_state *css)
>  {
>  	/* We don't need to reference count the root state */
>  	if (!(css->flags & CSS_ROOT))
> -		__css_get(css, 1);
> +		atomic_inc(&css->refcnt);
>  }
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/