linux-kernel - Re: [PATCH 2/2] rtc: omap: add rtc wakeup support to alarm events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k3lxabyg.fsf@linaro.org>
Date:	Thu, 13 Jun 2013 15:21:43 -0700
From:	Kevin Hilman <khilman@...aro.org>
To:	"Hebbar\, Gururaja" <gururaja.hebbar@...com>
Cc:	"akpm\@linux-foundation.org" <akpm@...ux-foundation.org>,
	"linux\@arm.linux.org.uk" <linux@....linux.org.uk>,
	"zonque\@gmail.com" <zonque@...il.com>,
	"linux-arm-kernel\@lists.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"grant.likely\@linaro.org" <grant.likely@...aro.org>,
	"rob.herring\@calxeda.com" <rob.herring@...xeda.com>,
	"rob\@landley.net" <rob@...dley.net>,
	"a.zummo\@towertech.it" <a.zummo@...ertech.it>,
	"devicetree-discuss\@lists.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linux-doc\@vger.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	"rtc-linux\@googlegroups.com" <rtc-linux@...glegroups.com>,
	"davinci-linux-open-source\@linux.davincidsp.com" 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	"Bedia\, Vaibhav" <vaibhav.bedia@...com>,
	"Rajashekhara\, Sudhakar" <sudhakar.raj@...com>
Subject: Re: [PATCH 2/2] rtc: omap: add rtc wakeup support to alarm events

"Hebbar, Gururaja" <gururaja.hebbar@...com> writes:

> Hi Kevin,
>
> On Mon, Jun 10, 2013 at 16:55:17, Hebbar, Gururaja wrote:
>> On Fri, May 31, 2013 at 23:11:22, Kevin Hilman wrote:
>> > Hebbar Gururaja <gururaja.hebbar@...com> writes:
>> > 
>> > > On some platforms (like AM33xx), a special register (RTC_IRQWAKEEN)
>> > > is available to enable Wakeup feature for Alarm Events.
>> > >
>> > > Since new platforms/Boards are now added through DT only, this feature
>> > > is supported via DT property only.
>> > 
>> > > Platforms using such IP should add the property "ti,has_irq_wake_enb"
>> > > in rtc DT node.
>> > 
>> > This is a property of the IP, not the board.  Can't you detect this
>> > based on the revision of the IP?
>> 
>> Here is what I found out till now.
>> 
>> 1. rtc-omap driver is used by Davinci, OMAP-1/2 & AM33xx SoC.
>> 
>> 2. Only AM33xx soc rtc ip has revision register (& populated). Older OMAP
>>    Or davinci doesn't have this register.
>> 
>> 3. AFAIK, this was the reason why Afzal used platform_device_id & 
>>    of_device_id->data method to detect new versions (commit
>>    9e0344dcc225fe1a0e8b8af9ff7df44ec4613580)
>> 
>> 
>> So now either 
>> a. I can follow the same method and add new member to omap_rtc_devtype & add a new compatible in 
>>  omap_rtc_of_match in rtc-omap.c
>> 
>> or
>> 
>> b. use dt property to indicate existence of above property.
>> 
>> 
>> Kindly let me know your opinion about the same.
>
> Any update on this. I have patch ready for both the choices. Waiting for your ok to send

I think (a) is better.

The driver should always do a device_init_wakeup(dev, true), *except*
for devtypes that don't have this feature.

Kevin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/