linux-kernel - Re: [PATCH] slub: Avoid direct compaction if possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51BB33FE.1020403@yandex-team.ru>
Date:	Fri, 14 Jun 2013 19:17:18 +0400
From:	Roman Gushchin <klamm@...dex-team.ru>
To:	Christoph Lameter <cl@...two.org>
CC:	penberg@...nel.org, mpm@...enic.com, akpm@...ux-foundation.org,
	mgorman@...e.de, rientjes@...gle.com, glommer@...allels.com,
	hannes@...xchg.org, minchan@...nel.org, jiang.liu@...wei.com,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] slub: Avoid direct compaction if possible

On 14.06.2013 18:32, Christoph Lameter wrote:
> On Fri, 14 Jun 2013, Roman Gushchin wrote:
>
>> Slub tries to allocate contiguous pages even if memory is fragmented and
>> there are no free contiguous pages. In this case it calls direct compaction
>> to allocate contiguous page. Compaction requires the taking of some heavily
>> contended locks (e.g. zone locks). So, running compaction (direct and using
>> kswapd) simultaneously on several processors can cause serious performance
>> issues.
>
> The main thing that this patch does is to add a nocompact flag to the page
> allocator. That needs to be a separate patch. Also fix the description.
> Slub does not invoke compaction. The page allocator initiates compaction
> under certain conditions.

Ok, I'll do.

>
>> It's possible to avoid such problems (or at least to make them less probable)
>> by avoiding direct compaction. If it's not possible to allocate a contiguous
>> page without compaction, slub will fall back to order 0 page(s). In this case
>> kswapd will be woken to perform asynchronous compaction. So, slub can return
>> to default order allocations as soon as memory will be de-fragmented.
>
> Sounds like a good idea. Do you have some numbers to show the effect of
> this patch?

No.
It seems that any numbers here depend on memory fragmentation,
so it's not easy to make a reproducible measurement. If you have
any ideas here, you are welcome.

But there is an actual problem, that this patch solves.
Sometimes I saw the following issue on some machines:
all CPUs are performing compaction, system time is about 80%,
system is completely unreliable. It occurs only on machines
with specific workload (distributed data storage system, so,
intensive disk i/o is performed). A system can fall into
this state fast and unexpectedly or by progressive degradation.

This patch solves this problem.

Thank you for your comments and suggestions!

Regards,
Roman

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/