linux-kernel - Re: [PATCH v2 2/2] spi: omap2-mcspi: Add FIFO buffer support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51BB41CC.9080403@ti.com>
Date:	Fri, 14 Jun 2013 19:16:12 +0300
From:	Illia Smyrnov <x0194613@...com>
To:	Mark Brown <broonie@...nel.org>
CC:	Illia Smyrnov <illia.smyrnov@...com>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <rob.herring@...xeda.com>,
	Rob Landley <rob@...dley.net>, Daniel Mack <zonque@...il.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Tony Lindgren <tony@...mide.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<devicetree-discuss@...ts.ozlabs.org>, <linux-doc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	<spi-devel-general@...ts.sourceforge.net>,
	<linux-omap@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] spi: omap2-mcspi: Add FIFO buffer support



On 06/12/2013 06:47 PM, Mark Brown wrote:
> On Tue, Jun 11, 2013 at 08:09:15PM +0300, Illia Smyrnov wrote:
>> The MCSPI controller has a built-in FIFO buffer to unload the DMA or interrupt
>> handler and improve data throughput. This patch adds FIFO buffer support for SPI
>> transfers in DMA mode.
>
>> The FIFO could be enabled for SPI module by setting up the "ti,spi-fifo-enabled"
>> configuration parameter in DT.
>> If FIFO enabled, the largest possible FIFO buffer size will be calculated and
>> setup for each SPI transfer. Even if the FIFO is enabled in DT, it won't be used
>> for the SPI transfers when: calculated FIFO buffer size is less then 2 bytes or
>> the FIFO buffer size isn't multiple of the SPI word length.
>
> Why is the default to disable the FIFO?
>

I have changed this and sent v3 patches of the MCSPI FIFO support 
implementation. In this version driver set up the FIFO (if possible) for 
all the SPI transfers in DMA mode.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/