linux-kernel - Re: [PATCH] drm/omap: change "!CONFIG_FB_OMAP2" to "!FB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130615100935.GA2477@mithrandir>
Date:	Sat, 15 Jun 2013 12:09:36 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	David Airlie <airlied@...ux.ie>, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/omap: change "!CONFIG_FB_OMAP2" to "!FB_OMAP2"

On Wed, Mar 13, 2013 at 08:48:22PM +0100, Paul Bolle wrote:
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> ---
> Untested. Perhaps the first test that people with access to the relevant
> hardware might do, is to test _before applying this patch_ with FB_OMAP2
> set. Perhaps this negative dependency isn't needed at all. Or is it
> obvious?

I don't think you need access to hardware to test this. Checking that
the dependencies work properly (using menuconfig for example) and
build testing should be enough.

>  drivers/gpu/drm/omapdrm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconfig
> index 09f65dc..45875a0 100644
> --- a/drivers/gpu/drm/omapdrm/Kconfig
> +++ b/drivers/gpu/drm/omapdrm/Kconfig
> @@ -1,7 +1,7 @@
>  
>  config DRM_OMAP
>  	tristate "OMAP DRM"
> -	depends on DRM && !CONFIG_FB_OMAP2
> +	depends on DRM && !FB_OMAP2
>  	depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM
>  	depends on OMAP2_DSS
>  	select DRM_KMS_HELPER

Regardless of whether the dependency is needed or not, the typo should
be fixed, so:

Reviewed-by: Thierry Reding <thierry.reding@...il.com>

Content of type "application/pgp-signature" skipped