linux-kernel - Re: [PATCH] drm/omap: change "!CONFIG_FB_OMAP2" to "!FB_OMAP2"

Open Source and information security mailing list archives

Message-ID: <CAF6AEGs_LS1ZFFj+C67dmRj4G122O1YSqTH_EpgtkLkQOKb2LQ@mail.gmail.com>
Date:	Sat, 15 Jun 2013 08:20:35 -0400
From:	Rob Clark <robdclark@...il.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	David Airlie <airlied@...ux.ie>, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/omap: change "!CONFIG_FB_OMAP2" to "!FB_OMAP2"

On Thu, Jun 13, 2013 at 6:31 AM, Paul Bolle <pebolle@...cali.nl> wrote:
> On Wed, 2013-03-13 at 20:48 +0100, Paul Bolle wrote:
>> Signed-off-by: Paul Bolle <pebolle@...cali.nl>
>> ---
>> Untested. Perhaps the first test that people with access to the relevant
>> hardware might do, is to test _before applying this patch_ with FB_OMAP2
>> set. Perhaps this negative dependency isn't needed at all. Or is it
>> obvious?
>>
>>  drivers/gpu/drm/omapdrm/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> This patch was sent exactly three months ago, shortly after v3.9-rc2 was
> released. This obvious typo is still present in v3.10-rc5.
>
> I didn't received any feedback on this patch. Did anyone had a look at
> it? Is it perhaps queued somewhere?

oh, sorry, at the time I was in the middle of moving, and wasn't
watching dri-devel so much.

Yeah, this should probably either be merged, or we should just drop
the negative dependency.  (I guess in theory you could build both
omapfb and omapdrm as modules and just load one.)

BR
-R

>
> Paul Bolle
>
>> diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconfig
>> index 09f65dc..45875a0 100644
>> --- a/drivers/gpu/drm/omapdrm/Kconfig
>> +++ b/drivers/gpu/drm/omapdrm/Kconfig
>> @@ -1,7 +1,7 @@
>>
>>  config DRM_OMAP
>>       tristate "OMAP DRM"
>> -     depends on DRM && !CONFIG_FB_OMAP2
>> +     depends on DRM && !FB_OMAP2
>>       depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM
>>       depends on OMAP2_DSS
>>       select DRM_KMS_HELPER
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives