linux-kernel - Re: [PATCH v3] i2c: vt8500: Add support for I2C bus on Wondermedia SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51BCE39D.4030505@prisktech.co.nz>
Date:	Sun, 16 Jun 2013 09:58:53 +1200
From:	Tony Prisk <linux@...sktech.co.nz>
To:	Wolfram Sang <wsa@...-dreams.de>
CC:	vt8500-wm8505-linux-kernel@...glegroups.com,
	linux-arm-kernel@...ts.infradead.org, linux@....linux.org.uk,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] i2c: vt8500: Add support for I2C bus on Wondermedia
 SoCs

On 15/06/13 23:18, Wolfram Sang wrote:
> On Sat, Jun 15, 2013 at 09:52:16AM +1200, Tony Prisk wrote:
>> This patch adds support for the I2C bus controllers found on Wondermedia
>> 8xxx-series SoCs. Only master-mode is supported.
>>
>> Signed-off-by: Tony Prisk <linux@...sktech.co.nz>
>> ---
> ...
>
>> +/* REG_TR */
>> +#define SCL_TIMEOUT(x)		(((x) & 0xFF) << 16)
> I assume this should be << 8 since all regs are 16 bit wide.
>
> Fixed it locally and ready to apply. Please confirm or send a proper
> fix. Rest looks fine.
>
> Thanks for the submission!
>
It should be << 8. Please apply your locally corrected version.

Regards
Tony Prisk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/