lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 15 Jun 2013 06:26:31 +0100 From: Al Viro <viro@...IV.linux.org.uk> To: Dave Chiluk <chiluk@...onical.com> Cc: Petr Vandrovec <petr@...drovec.name>, linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org, Linus Torvalds <torvalds@...ux-foundation.org> Subject: Re: [PATCH] ncpfs: fix rmdir returns Device or resource busy On Sat, Jun 15, 2013 at 06:09:39AM +0100, Al Viro wrote: > BTW, in ncp_fill_cache() we have a provably pointless > if (!ino) > ino = find_inode_number(dentry, &qname); > Check it out - any path that can lead there with ino == 0 will *not* > have a positive dentry with such name, so this find_inode_number() > call is just "waste some time and return 0". Cargo-cult, plain and > simple... Incidentally, the only other caller of find_inode_number() is equally pointless, so I'm very inclined to kill the damn function off. Sure, it's exported. And I'm fairly sure that its out-of-tree users are just as fishy (as in Innsmouth)... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists