linux-kernel - Re: [PATCH 0/6] ipc/sem.c: performance improvements, FIFO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51BBFB34.20206@colorfullife.com>
Date:	Sat, 15 Jun 2013 07:27:16 +0200
From:	Manfred Spraul <manfred@...orfullife.com>
To:	Mike Galbraith <efault@....de>
CC:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Rik van Riel <riel@...hat.com>,
	Davidlohr Bueso <davidlohr.bueso@...com>, hhuang@...hat.com,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 0/6] ipc/sem.c: performance improvements, FIFO

On 06/14/2013 09:05 PM, Mike Galbraith wrote:
> 32 of 64 cores DL980 without the -rt killing goto again loop removal I
> showed you.  Unstable, not wonderful throughput.
Unfortunately the -rt approach is defintively unstable:
> @@ -285,9 +274,29 @@ static inline int sem_lock(struct sem_ar
>                  * but have to wait for the global lock to be released.
>                  */
>                 if (unlikely(spin_is_locked(&sma->sem_perm.lock))) {
> -                       spin_unlock(&sem->lock);
> - spin_unlock_wait(&sma->sem_perm.lock);
> -                       goto again;
> +                       spin_lock(&sma->sem_perm.lock);
> +                       if (sma->complex_count)
> +                               goto wait_array;
> +
> +                       /*
> +                        * Acquiring our sem->lock under the global lock
> +                        * forces new complex operations to wait for us
> +                        * to exit our critical section.
> +                        */
> +                       spin_lock(&sem->lock);
> +                       spin_unlock(&sma->sem_perm.lock);

Assume there is one op (semctl(), whatever) that acquires the global 
lock - and a continuous stream of simple ops.
- spin_is_locked() returns true due to the semctl().
- then simple ops will switch to spin_lock(&sma->sem_perm.lock).
- since the spinlock is acquired, the next operation will get true from 
spin_is_locked().

It will stay that way around - as long as there is at least one op 
waiting for sma->sem_perm.lock.
With enough cpus, it will stay like this forever.

--
     Manfred
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/