linux-kernel - Re: [PATCH] uprobes: fix return value in error handling path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1371488199.18733.20.camel@gandalf.local.home>
Date:	Mon, 17 Jun 2013 12:56:39 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	"zhangwei(Jovi)" <jovi.zhangwei@...wei.com>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	srikar@...ux.vnet.ibm.com,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] uprobes: fix return value in error handling path

Srikar,

Can you give an Ack (or nack) for this?

Thanks,

-- Steve


On Thu, 2013-06-13 at 14:21 +0800, zhangwei(Jovi) wrote:
> When I inject incorrect argument into uprobe_events,
> 
> [root@...i tracing]# echo 'p:myprobe /bin/bash' > uprobe_events
> [root@...i tracing]#
> 
> it doesn't return any error value in there, this patch fix it.
> 
> Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@...wei.com>
> ---
>  kernel/trace/trace_uprobe.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index 32494fb0..d5d0cd3 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -283,8 +283,10 @@ static int create_trace_uprobe(int argc, char **argv)
>  		return -EINVAL;
>  	}
>  	arg = strchr(argv[1], ':');
> -	if (!arg)
> +	if (!arg) {
> +		ret = -EINVAL;
>  		goto fail_address_parse;
> +	}
> 
>  	*arg++ = '\0';
>  	filename = argv[1];


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/