linux-kernel - Re: [PATCH] mm: Remove unlikely from the current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1306171656050.24663@chino.kir.corp.google.com>
Date:	Mon, 17 Jun 2013 16:56:17 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Zhang Yanfei <zhangyanfei.yes@...il.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux MM <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: Remove unlikely from the current_order test

On Tue, 18 Jun 2013, Zhang Yanfei wrote:

> From: Zhang Yanfei <zhangyanfei@...fujitsu.com>
> 
> In __rmqueue_fallback(), current_order loops down from MAX_ORDER - 1
> to the order passed. MAX_ORDER is typically 11 and pageblock_order
> is typically 9 on x86. Integer division truncates, so pageblock_order / 2
> is 4.  For the first eight iterations, it's guaranteed that
> current_order >= pageblock_order / 2 if it even gets that far!
> 
> So just remove the unlikely(), it's completely bogus.
> 
> Suggested-by: David Rientjes <rientjes@...gle.com>
> Signed-off-by: Zhang Yanfei <zhangyanfei@...fujitsu.com>

Acked-by: David Rientjes <rientjes@...gle.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/