linux-kernel - Re: [PATCH]amilo-rfkill: add depends on i8042 in Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1371560680.3495.121.camel@deadeye.wl.decadent.org.uk>
Date:	Tue, 18 Jun 2013 14:04:40 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Xiong Zhou <jencce.kernel@...il.com>
Cc:	matthew.garrett@...ula.com, platform-driver-x86@...r.kernel.org,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>, jim.epost@...il.com
Subject: Re: [PATCH]amilo-rfkill: add depends on i8042 in Kconfig

On Tue, 2013-06-18 at 17:21 +0800, Xiong Zhou wrote:
> From: Xiong Zhou <jencce.kernel@...il.com>
> 
> Fix randconfig build failure for Amilo x86 platform driver.
> AMILO_RFKILL requires SERIO_I8042 being available.
> 
> amilo-rfkill.c:(.text+0x108b5b): undefined reference to `i8042_lock_chip'
> amilo-rfkill.c:(.text+0x108b69): undefined reference to `i8042_command'
> amilo-rfkill.c:(.text+0x108b71): undefined reference to `i8042_unlock_chip'
> 
> Reported-by: Jim Davis <jim.epost@...il.com>
> Signed-off-by: Xiong Zhou <jencce.kernel@...il.com>

Acked-by: Ben Hutchings <ben@...adent.org.uk>

But I thought somehow sent this same fix a while back...

Ben.

> ---
>  drivers/platform/x86/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 8577261..37645b9 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -176,6 +176,7 @@ config FUJITSU_TABLET
>  config AMILO_RFKILL
>  	tristate "Fujitsu-Siemens Amilo rfkill support"
>  	depends on RFKILL
> +	depends on SERIO_I8042
>  	---help---
>  	  This is a driver for enabling wifi on some Fujitsu-Siemens Amilo
>  	  laptops.

-- 
Ben Hutchings
Humans are not rational beings; they are rationalising beings.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)