linux-kernel - Re: [PATCH]amilo-rfkill: add depends on i8042 in Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51C07608.2070406@infradead.org>
Date:	Tue, 18 Jun 2013 08:00:24 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Ben Hutchings <ben@...adent.org.uk>
CC:	Xiong Zhou <jencce.kernel@...il.com>, matthew.garrett@...ula.com,
	platform-driver-x86@...r.kernel.org, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>, jim.epost@...il.com
Subject: Re: [PATCH]amilo-rfkill: add depends on i8042 in Kconfig

On 06/18/13 06:04, Ben Hutchings wrote:
> On Tue, 2013-06-18 at 17:21 +0800, Xiong Zhou wrote:
>> From: Xiong Zhou <jencce.kernel@...il.com>
>>
>> Fix randconfig build failure for Amilo x86 platform driver.
>> AMILO_RFKILL requires SERIO_I8042 being available.
>>
>> amilo-rfkill.c:(.text+0x108b5b): undefined reference to `i8042_lock_chip'
>> amilo-rfkill.c:(.text+0x108b69): undefined reference to `i8042_command'
>> amilo-rfkill.c:(.text+0x108b71): undefined reference to `i8042_unlock_chip'
>>
>> Reported-by: Jim Davis <jim.epost@...il.com>
>> Signed-off-by: Xiong Zhou <jencce.kernel@...il.com>
> 
> Acked-by: Ben Hutchings <ben@...adent.org.uk>
> 
> But I thought somehow sent this same fix a while back...

Yes, I reported it and sent a patch for it that you acked...
I guess my patch was never picked up.

> 
> Ben.
> 
>> ---
>>  drivers/platform/x86/Kconfig |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
>> index 8577261..37645b9 100644
>> --- a/drivers/platform/x86/Kconfig
>> +++ b/drivers/platform/x86/Kconfig
>> @@ -176,6 +176,7 @@ config FUJITSU_TABLET
>>  config AMILO_RFKILL
>>  	tristate "Fujitsu-Siemens Amilo rfkill support"
>>  	depends on RFKILL
>> +	depends on SERIO_I8042
>>  	---help---
>>  	  This is a driver for enabling wifi on some Fujitsu-Siemens Amilo
>>  	  laptops.
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/