linux-kernel - Re: [PATCH v2 1/4] MFD: Palmas: Check if interrupts property exists and then only request irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51C0820B.4020404@wwwdotorg.org>
Date:	Tue, 18 Jun 2013 09:51:39 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	J Keerthy <j-keerthy@...com>
CC:	linux-omap@...r.kernel.org, broonie@...nel.org,
	ldewangan@...dia.com, sameo@...ux.intel.com,
	grant.likely@...retlab.ca, swarren@...dia.com,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	gg@...mlogic.co.uk
Subject: Re: [PATCH v2 1/4] MFD: Palmas: Check if interrupts property exists
 and then only request irq

On 06/18/2013 04:01 AM, J Keerthy wrote:
> Check if interrupts property exists and then only request irq.
> On some boards INT line might not be connected to a valid
> irq line on the application processor. Hence keeping a check
> before requesting irq.

When there is no interrupts property, surely i2c->irq == 0, which is an
invalid IRQ, and hence there's no need to check this before copying the
value?

In other words, I think this whole patch could just be:

+ 	palmas->irq = i2c->irq;

right?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/