linux-kernel - Re: [PATCH 3/5] drivers/misc: rf/ad9361: AD9361 device driver for Radio phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Jun 2013 16:58:04 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	"Lars-Peter Clausen" <lars@...afoo.de>, akhil.goyal@...escale.com,
	linux-kernel@...r.kernel.org, pankaj.chauhan@...escale.com,
	"Getz, Robin" <robin.getz@...log.com>,
	"Hennerich, Michael" <Michael.Hennerich@...log.com>,
	"Lars-Peter Clausen" <lars-peter.clausen@...log.com>
Subject: Re: [PATCH 3/5] drivers/misc: rf/ad9361: AD9361 device driver for Radio phy

On Wednesday 19 June 2013, Greg KH wrote:
> On Wed, Jun 19, 2013 at 02:57:40PM +0200, Lars-Peter Clausen wrote:
> > On 06/17/2013 10:09 AM, akhil.goyal@...escale.com wrote:
> > 
> > This is interesting. We at Analog Devices are currently also working on a
> > driver for this part. We are using the Linux Industrial IO (IIO) framework
> > though, since the AD9361 is more or less a multifunction device implementing
> > different functions already covered by the IIO framework, like ADCs, DACs,
> > clock chips and so on.
> 
> That's the "proper" api for this, not a bunch of chip-custom ioctls that
> aren't documented anywhere.

Depending on what functions there are in the device, it might actually be
better to make the chip itself an MFD device, and have sub-functions handled
by drivers/iio, drivers/clk, drivers/pwm etc. For the bigger picture I
definitely agree: it should use the existing subsystems whereever possible.
It may well be that a single IIO device is the right answer in this case,
but a new subsystem that covers the entire chip and adds a custom user
interface is almost certainly not.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/