linux-kernel - Re: [PATCH] perf: arm64: Record the user-mode PC in the call chain.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130620091136.GC2842@mudshark.cambridge.arm.com>
Date:	Thu, 20 Jun 2013 10:11:37 +0100
From:	Will Deacon <will.deacon@....com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Jed Davis <jld@...illa.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...hat.com>,
	Catalin Marinas <Catalin.Marinas@....com>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Subject: Re: [PATCH] perf: arm64: Record the user-mode PC in the call chain.

On Thu, Jun 20, 2013 at 09:33:28AM +0100, Ingo Molnar wrote:
> 
> * Jed Davis <jld@...illa.com> wrote:
> 
> > With this change, we no longer lose the innermost entry in the user-mode
> > part of the call chain.  See also the x86 port, which includes the ip,
> > and the corresponding change in arch/arm.
> > 
> > Signed-off-by: Jed Davis <jld@...illa.com>
> > ---
> >  arch/arm64/kernel/perf_event.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
> > index 1e49e5eb..9ba33c4 100644
> > --- a/arch/arm64/kernel/perf_event.c
> > +++ b/arch/arm64/kernel/perf_event.c
> > @@ -1336,6 +1336,7 @@ void perf_callchain_user(struct perf_callchain_entry *entry,
> >  		return;
> >  	}
> >  
> > +	perf_callchain_store(entry, regs->pc);
> >  	tail = (struct frame_tail __user *)regs->regs[29];
> >  
> >  	while (entry->nr < PERF_MAX_STACK_DEPTH &&
> 
> Acked-by: Ingo Molnar <mingo@...nel.org>
> 
> I suspect this goes to v3.10 via the ARM64 tree?

Yup, we'll take this via the arm64 tree, thanks.

Catalin, you can add:

	Acked-by: Will Deacon <will.deacon@....com>

to this.

Cheers,

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/